Files app: remove unused LoaderType enum (CANVAS)

Nominally, there are two enum values: IMAGE and CANVAS. IMAGE is the
default (if passing undefined to the ThumbnailLoader constructor). The
only use of CANVAS is in test code (thumbnail_loader_unittest.ts) and
the tests are still green when passing IMAGE instead.

"CANVAS is only used in tests" is true in 2024 (today) and also true in
2018 (e.g. grepping the ui/file_manager/file_manager source code as of
commit f919e4565e1f3960548400a1349a23ee75ff7866,
https://chromium-review.googlesource.com/1212706).

That commit (in 2018) authored the thumbnail_loader_unittest.ts line 6
that is today (in 2024) the only place that passes CANVAS. But its use
of CANVAS (at line 6) is possibly copy/pasting itself (from line 204,
see link below). I suspect that the test doesn't actually care about the
IMAGE vs CANVAS choice.

https://chromium-review.googlesource.com/c/chromium/src/+/1212706/6/ui/file_manager/file_manager/foreground/js/thumbnail_loader_unittest.js

Bug: b/319190834
Change-Id: Ia860b9b5cdbd68cf623f455cfb8ff258b3701486
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5664623
Auto-Submit: Nigel Tao <nigeltao@chromium.org>
Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1323859}
4 files changed
tree: eea7ba57fbfe2902e6c20b99caea16e779a86ae8
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. .clang-format
  52. .clang-tidy
  53. .clangd
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitallowed
  57. .gitattributes
  58. .gitignore
  59. .gitmodules
  60. .gn
  61. .mailmap
  62. .rustfmt.toml
  63. .vpython3
  64. .yapfignore
  65. ATL_OWNERS
  66. AUTHORS
  67. BUILD.gn
  68. CODE_OF_CONDUCT.md
  69. codereview.settings
  70. CPPLINT.cfg
  71. DEPS
  72. DIR_METADATA
  73. LICENSE
  74. LICENSE.chromium_os
  75. OWNERS
  76. PRESUBMIT.py
  77. PRESUBMIT_test.py
  78. PRESUBMIT_test_mocks.py
  79. README.md
  80. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.