Google Git
Sign in
chromium / chromium / src / ca82576a2716429d5c311c673e36cb7bdf65e360
commitca82576a2716429d5c311c673e36cb7bdf65e360[log] [tgz]
authorTina Wang <tinazwang@google.com>Wed Jul 13 23:37:21 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Jul 13 23:37:21 2022
treeeb65396c8c050cfbe35b69270fa4d8215d6e20e6
parentf02992ffd3d9d7ca699a48022be4b7f3993e7589 [diff]
[FollowIPH] Don't show Follow IPH in incognito mode

Crash happens when a follow recommended page loaded in incognito mode
and we try to show an follow IPH, because the MetricsRecorder can't
be generated in an incognito browser.

To fix that now, we don't show the follow IPH in incognito mode.

WIP: checking more conditions before showing a follow IPH, and move
the checking logic to follow_iph_presenter_ so we won't need to
inject any pointer get from BrowserState in the future.

Bug: 1344217
Change-Id: Iec90d826415df353d996dfa455b9c17685139379
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3758369
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: Tina Wang <tinazwang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1023996}
1 file changed
tree: eb65396c8c050cfbe35b69270fa4d8215d6e20e6
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython
  61. .vpython3
  62. .yapfignore
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. ENG_REVIEW_OWNERS
  70. LICENSE
  71. LICENSE.chromium_os
  72. OWNERS
  73. PRESUBMIT.py
  74. PRESUBMIT_test.py
  75. PRESUBMIT_test_mocks.py
  76. README.md
  77. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.