Prevent access to an unset optional in BFCache Metrics. This happens when user navigates forwards and backwards quickly, before `MainFrameDidNavigateAwayFromDocument` is called AND for the renderer is killed. It seems like this should be quite rare but we have at least one crash report. This might bewhat was generating the previous crashes since it's the crash looks the same: `SIGABRT @0x00000000`. Also upgrade a DCHECK to a CHECK. There was a DCHECK for the bad timestamp and if it had been a CHECK, debugging this would have been much easier. Bug: 427426299 Change-Id: I04f9436e604f15dbdb779de7bac600ab7010fea8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6731580 Commit-Queue: Fergal Daly <fergal@chromium.org> Reviewed-by: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/main@{#1486810}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.