commit | ca9579b7a2f0aa0baafa96373ffefcca248c58f5 | [log] [tgz] |
---|---|---|
author | Maria Kazinova <kazinova@google.com> | Mon Dec 20 15:43:00 2021 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Dec 20 15:43:00 2021 |
tree | 814a39671bc8e440a88d4a824fc926e5ecc2de85 | |
parent | 04abd486fbc2d77f602909d132a3c27bbc890ed0 [diff] |
Move password generation requirements propagation to PasswordManager. When server predictions are received, a call to PasswordGenerationHelper::ProcessPasswordRequirements should be made. Previously it was AutofillClient's responsibility to call this, which lead to bugs, because there are multiple implementations of AutofillClient (e.g. cross-platform, iOS, web_view), and it's easy to forget this call. This CL makes password generation requirements propagation a part of PasswordManager::ProcessAutofillPredictions, and allows to have a single point of calling it in the code. With this CL ios/web_view will start receiving password generation requirements. Change-Id: I9d8a802971490690a4ba78ceb814b5fd81cc7200 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3311296 Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by: David Roger <droger@chromium.org> Commit-Queue: Maria Kazinova <kazinova@google.com> Cr-Commit-Position: refs/heads/main@{#952927}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.