commit caae7e41c992e880fb30fae95c8bfc87e99b55e7
author Carlos IL <carlosil@chromium.org> Thu Mar 07 22:27:49 2019
committer Commit Bot <commit-bot@chromium.org> Thu Mar 07 22:27:49 2019
tree c334103eccbbfb4ff5bd3ac4fd605adf89b6fb5d
parent 2b37cc99344614edff9e52c82844aa4d078e8067

Reland "Refactor SSLCertificateErrorPageController"

This reverts commit 30645e2f17efd8cfaf09c6f332cdf333282d2ef7.

Reason for revert: Failures reproduce locally on commits prior to this CL.

Original change's description:
> Revert "Refactor SSLCertificateErrorPageController"
>
> This reverts commit 08c128cd49af9bfb4ded6298441e158b41849061.
>
> Reason for revert: Reverterd on suspicion of causing build failures on Mac 10.11
>
> TBR: carlosil@chromium.org
>
> failures:
> SSLClientSocketReadTest.Read/1
> SSLClientSocketReadTest.Read/0
> HTTPSEVCRLSetTest.FreshCRLSetNotCovered
> WebSocketEndToEndTest.BasicSmokeTest
> SSLClientSocketReadTest.DumpMemoryStats/0
> SSLClientSocketReadTest.DumpMemoryStats/1
> URLRequestTestFTP.FTPCheckWrongUser
> WebSocketEndToEndTest.TruncatedResponse
> WebSocketEndToEndTest.HstsWebSocketToWebSocket
> WebSocketEndToEndTest.TrailingWhitespace
> HTTPSOCSPTest.IntermediateResponseTooOld
> URLRequestTestFTP.FTPCheckWrongUserRestart
> URLRequestTestFTP.FTPCheckWrongPasswordRestart
> HTTPSOCSPTest.Revoked
> HTTPSFallbackTest.TLSv1_1NoFallback
> HTTPSFallbackTest.TLSv1_3Interference
> URLRequestTestFTP.FTPCheckWrongPassword
> WebSocketEndToEndTest.HeaderContinuations
> HTTPSCRLSetTest.ExpiredCRLSetAndRevoked
> HTTPSEVCRLSetTest.FreshCRLSetCovered
> SSLClientSocketReadTest.Read_DeleteWhilePendingFullDuplex/1
> SSLClientSocketReadTest.Read_DeleteWhilePendingFullDuplex/0
> OCSPVerify/HTTPSOCSPVerifyTest.VerifyResult/18
> HTTPSOCSPTest.Valid
> HTTPSEVCRLSetTest.ExpiredCRLSet
> OCSPVerify/HTTPSOCSPVerifyTest.VerifyResult/12
> OCSPVerify/HTTPSOCSPVerifyTest.VerifyResult/13
> OCSPVerify/HTTPSOCSPVerifyTest.VerifyResult/10
> OCSPVerify/HTTPSOCSPVerifyTest.VerifyResult/11
> OCSPVerify/HTTPSOCSPVerifyTest.VerifyResult/16
> … 70 more (100 total) …
>
> Original change's description:
> > Refactor SSLCertificateErrorPageController
> >
> > SSLCertificateErrorPageController is no longer only used on SSL errors,
> > renamed it to SecurityInterstitialErrorPageController, and removed the
> > net::Error code passed to EnablePageHelperFunctions since it's no
> > longer used.
> >
> > Bug: 910794
> > Change-Id: I718e0fcbcb2643cb0c47818dda1f317aef4e75cc
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503910
> > Reviewed-by: Matt Menke <mmenke@chromium.org>
> > Reviewed-by: Scott Violet <sky@chromium.org>
> > Commit-Queue: Carlos IL <carlosil@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#638232}
>
> TBR=sky@chromium.org,mmenke@chromium.org,carlosil@chromium.org
>
> Change-Id: I39489effa3e0029b5ff65f5bc9cbd991aef1ddea
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 910794
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507039
> Reviewed-by: Peter Williamson <petewil@chromium.org>
> Commit-Queue: Peter Williamson <petewil@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#638363}

TBR=sky@chromium.org,petewil@chromium.org,mmenke@chromium.org,carlosil@chromium.org

Change-Id: I5b9048e43ebc60964c44ebfd2c05207a22a549dc
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 910794
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1509352
Reviewed-by: Carlos IL <carlosil@chromium.org>
Commit-Queue: Carlos IL <carlosil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638773}