Google Git
Sign in
chromium / chromium / src / cad10f78fed6f86bc7c34f18ec32e05ddc46451c
commitcad10f78fed6f86bc7c34f18ec32e05ddc46451c[log] [tgz]
authorAndres Ricardo Perez <andresrperez@chromium.org>Tue Jul 02 15:25:58 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue Jul 02 15:25:58 2024
tree7eb7aebb102a054d9e00b4dffa7a6c8fc35ce937
parent5d2cbdb30fc9ae14f2588dd9f3803a0354f1ec66 [diff]
Add <h1> tag to grid templates in generated canvas tests

Since an explicit <body> tag wasn't present in the template for variant
grids, it was not possible to attach and remove children from
`document.body`. This is working already for offscreen tests that don't
use grids, since the <h1> tag they use to place the test name creates
an implicit <body>. This change adds this same <h1> tag to both grid
templates.

In a follow-up CL in the stack, this tag is used to compare via assert
values calculated from a Canvas Text API to their counterpart from text
placed in the DOM.

Bug: 341213359
Change-Id: Id9d084adc261195601b0b9748e2bc0df5b8b0b59
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5593277
Reviewed-by: Jean-Philippe Gravel <jpgravel@chromium.org>
Commit-Queue: Andres Ricardo Perez <andresrperez@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1322182}
6 files changed
tree: 7eb7aebb102a054d9e00b4dffa7a6c8fc35ce937
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. CPPLINT.cfg
  77. DEPS
  78. DIR_METADATA
  79. LICENSE
  80. LICENSE.chromium_os
  81. OWNERS
  82. PRESUBMIT.py
  83. PRESUBMIT_test.py
  84. PRESUBMIT_test_mocks.py
  85. README.md
  86. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.