Google Git
Sign in
chromium / chromium / src / cb724e480ec3ec5d6b9b085bca5117f0bfccf83f
commitcb724e480ec3ec5d6b9b085bca5117f0bfccf83f[log] [tgz]
authorHenrique Nakashima <hnakashima@chromium.org>Tue May 28 20:27:10 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue May 28 20:27:10 2024
tree24e65f6a89cf27c7746a5da937cf7f492eddbf8f
parent57e8d0c42a008fd0dab587433840d8907e9c578e [diff]
[Android] Remove scopedViewElement()

Scope.CONDITIONAL_STATE_SCOPED is not useful anymore. The exit Condition
used to check that the exact View instance that the enter Condition
matched did not exist anymore, but for a while it has checked that no
View matches the ViewElement anymore. Therefore, it doesn't make sense
to check that a ViewElement doesn't exist anymore in the exit Condition
in the same Transition that has an enter Condition that a ViewElement
with the same id exists.

This CL removed Scope.CONDITIONAL_STATE_SCOPED and renames
Scope.SHARED to Scope.SCOPED. The public API scopedViewElement() is
removed and usages are converted to viewElement(), which is an alias to
sharedViewElement(), which is the default scope.

Bug: None
Change-Id: Ic955ebe3234217de22e896690e3b1a263e5e0dfb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5576776
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1306997}
5 files changed
tree: 24e65f6a89cf27c7746a5da937cf7f492eddbf8f
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. CPPLINT.cfg
  77. DEPS
  78. DIR_METADATA
  79. LICENSE
  80. LICENSE.chromium_os
  81. OWNERS
  82. PRESUBMIT.py
  83. PRESUBMIT_test.py
  84. PRESUBMIT_test_mocks.py
  85. README.md
  86. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.