Google Git
Sign in
chromium / chromium / src / cb83b3301b02f67858a3e056d7ee6fbb6c8011aa
commitcb83b3301b02f67858a3e056d7ee6fbb6c8011aa[log] [tgz]
authorWen-Chien Wang <wcwang@chromium.org>Mon Jul 11 18:05:36 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Mon Jul 11 18:05:36 2022
tree2df1553bb940ffa0328da595620c11e251abb32f
parenta0e0791299101764fb47f4b63a6640c485e0813a [diff]
Replace LabelButton by PillButton for LoginShelfButton

This cl migrates the shelf buttons in login page to use PillButton in
ash/style. Detail changes are listed below.

1. Migrate the LoginShelfButton to use PillButton while keeping its original height.
2. Make the height of the PillButton mutable.
3. Updated the layout manager in Login shelf to make the layout easier
to read.
4. Small change on the PillButton layout that the padding on the text
side is wider than the icon side.
5. Updated the layout of Kiosk button on LoginShelfView so that it
looks the same as LoginShelfButton.

Bug: 1268660, 1324776
Change-Id: Ibb3fa70273fa8ad863e1e609fb04160be0426e6f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3620963
Reviewed-by: Min Chen <minch@chromium.org>
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Commit-Queue: Wen-Chien Wang <wcwang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1022777}
5 files changed
tree: 2df1553bb940ffa0328da595620c11e251abb32f
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython
  61. .vpython3
  62. .yapfignore
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. ENG_REVIEW_OWNERS
  70. LICENSE
  71. LICENSE.chromium_os
  72. OWNERS
  73. PRESUBMIT.py
  74. PRESUBMIT_test.py
  75. PRESUBMIT_test_mocks.py
  76. README.md
  77. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.