Google Git
Sign in
chromium / chromium / src / cb895fb12b11a072404bcce917d7fb6ac0ec6eeb
commitcb895fb12b11a072404bcce917d7fb6ac0ec6eeb[log] [tgz]
authorAlexey Baskakov <loyso@chromium.org>Tue Apr 20 00:07:12 2021
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue Apr 20 00:07:12 2021
tree88a86e6625339d0630e71647c2852b6d1772baad
parentfc4e481943a2af8daf528de31879a2c0084bcaf8 [diff]
NotificationService: Plumb document_url for non-persistent notifications.

We pass document_url as a notification metadata.

An origin can have multiple web apps with different document urls
(web frames).

A general note on frames vs documents mapping:

Ideally, at some point we would like the RenderFrameHost to be 1:1
with a document. A frame is 1:1 with FrameTreeNode. Today, the
RenderFrameHost is still reused for some same-site navigation and
renewed otherwise.

When fully 1:1 with document, renderFrameHost->GetLastCommitedURL()
and most properties of the RFH will become immutable.

A frame has a src, a document has an url. We use document_src over
frame_src in this CL to be more correct conceptually.

Bug: 1190648
Change-Id: I3dc1f696b195b1a4b2fb81211101de34cbce4837
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2781233
Commit-Queue: Alexey Baskakov <loyso@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#874042}
21 files changed
tree: 88a86e6625339d0630e71647c2852b6d1772baad
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .vpython
  61. .vpython3
  62. .yapfignore
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. ENG_REVIEW_OWNERS
  70. LICENSE
  71. LICENSE.chromium_os
  72. OWNERS
  73. PRESUBMIT.py
  74. PRESUBMIT_test.py
  75. PRESUBMIT_test_mocks.py
  76. README.md
  77. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.