commit cb8b9c3dc443ae18101f3f9527f8c8933d478756
author Salvador Guerrero <salg@google.com> Mon May 22 22:02:26 2023
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon May 22 22:02:26 2023
tree f99c947cca0321fa61d8c3edb5949dfec691624e
parent deaf7dedbc25032f982fe4da098ffa1eeefd1f70

Fixed toolbar capture ignoring optional button updates

Toolbar captures are skipped if the toolbar's state hasn't changed. The
container for toolbar state is PhoneCaptureStateToken. This class
keeps a reference to ButtonData, which represents the state of the
optional toolbar button and it uses standard equality checks to
determine of the optional button has changed. This works if the
button is updated with a new instance of ButtonData, but many providers
reuse the same instance, just changing its properties. This results in
button updates (e.g. when changing the button type from settings) not
triggering a new toolbar capture.

This CL updates ButtonData to implement its hashCode() method, this gets
used by PhoneCaptureStateToken to determine if the same instance of
ButtonData changed its attributes.

Bug: 1445540
Change-Id: I3b393051e875df1301ccb093f569820c2eaeed28
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4550198
Code-Coverage: Findit <findit-for-me@appspot.gserviceaccount.com>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Salvador Guerrero Ramos <salg@google.com>
Cr-Commit-Position: refs/heads/main@{#1147502}