commit cbb85ac076b8c4e6ff217def71478ef82e67d2e4
author Ryan Sultanem <rsult@google.com> Thu Apr 03 15:24:46 2025
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Thu Apr 03 15:24:46 2025
tree 7234a7026a221499328fa359eaf037ac695ec51a
parent f8bc194b915362ba1aa181a1955eb0dbfc6cdc99

[B4B] Adapt Side Panel to support merge view of bookmarks

Prior to this CL:
- The side panel relied on getting the bookmark list shown from the
public extensions API though: `chrome.bookmarks.getTree()`.
- Most of the code in the Side panel relies on the extensions
structure `chrome.bookmarks.BookmarkTreeNode`.

The Side Panel is expected to show a merged view of the permanent
folders; e.g. BookmarksBar folder and Managed Bookmarks should be
shown as one folder containing all the nodes from both the account
and local bookmark folder. Similarly `Other` (all bookmarks) and
`Mobile` nodes should behave the same, even though those are flattened
in the side panel view.

To approach that; this CL introduces a new way to provide the
bookmarks to the side panel using `BookmarkMergedSurfaceService`:
- Adds a new handler function to retrieve the all current combined
permanent folders.
- Adds a `BookmarksTreeNode` Mojo type that maps to the existing
extension object, with the same needed elements.
- On the Ui side, a helper function allows to transform the Mojo
object to the extension object - this is needed for now to avoid
having huge mechanical changes (TODO added to investigate the need
to change all usages to Mojo element instead).

Changes in tests are only to adapt to the new function, no behavior
change is expected.
Added further unit tests for the handler.

Bug: b:380806881
Change-Id: Idfb85b3f866f07c8f521ce7568767983e97c4e22
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6239895
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Emily Shack <emshack@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Alison Gale <agale@chromium.org>
Commit-Queue: Ryan Sultanem <rsult@google.com>
Cr-Commit-Position: refs/heads/main@{#1442177}