| commit | cbc0069a430599c087f3ff7d16aaead66cdca1dd | [log] [tgz] |
|---|---|---|
| author | Christoph Schwering <schwering@google.com> | Tue Jan 28 23:30:33 2025 |
| committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue Jan 28 23:30:33 2025 |
| tree | c4e3923e597a188b4a7793f7400e4387fc6d70cb | |
| parent | c11d35d9ad52a6c12fc245d04c11b8b9d159a65b [diff] |
[Autofill] Fix primary key violation in PaymentsAutofillTable UpdateLocalCvc() does an INSERT if `old_credit_card->cvc.empty()`. This INSERT may violate the primary key if the old CVC is empty because decryption failed. As a result, we hit a CHECK. This CL fixes this by making the INSERT an INSERT OR REPLACE. A followup CL also removes of [D]CHECKs that may fail due to corrupted databases. Bug: 392169470 Change-Id: I9fa743da604a6aa87ec41be4ae4a568bfb052ffe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6197661 Reviewed-by: Vinny Persky <vinnypersky@google.com> Reviewed-by: Florian Leimgruber <fleimgruber@google.com> Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com> Commit-Queue: Christoph Schwering <schwering@google.com> Cr-Commit-Position: refs/heads/main@{#1412600}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.