Google Git
Sign in
chromium / chromium / src / cc4d947f76afea1dd0491cac12548bfd2247b4e2
commitcc4d947f76afea1dd0491cac12548bfd2247b4e2[log] [tgz]
authorTakashi Toyoshima <toyoshim@chromium.org>Tue Jun 24 08:38:34 2025
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue Jun 24 08:38:34 2025
treeeaa4b826ebb67b8877bebab1334dcc379587b281
parent29bf204de1ca72dd88eb7f8b30a48fc9b4e85b72 [diff]
NavigationThrottleRunner2: Decouple request and runner

This patch decouples the NavigationThrottleRunner from the
NavigationRequest, and makes it owned by the NavigationThrottleRegistry.
The registry will manage the runner v1 and v2 flip, behind a flag.

In the v2 runner, it allows more than one deferring throttle, and
this new abstraction at the NavigationThrottleRegistryImpl defines
a modified API set to support the case. Currently, it just wraps the
v1 runner and calls the original API set to mimic the new API set.

The registry's callers should care for the multiple deferring throttles
after this change, though the actual underlying implementation may
support only one deferring throttle within the default config.

Bug: 422003056
Change-Id: I3f6c82103562b7ce5b5f7fd133a332ebd142be42
Low-Coverage-Reason: not regressed by this CL
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6644612
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1477778}
9 files changed
tree: eaa4b826ebb67b8877bebab1334dcc379587b281
  1. .github/
  2. android_webview/
  3. apps/
  4. ash/
  5. base/
  6. build/
  7. build_overrides/
  8. buildtools/
  9. cc/
  10. chrome/
  11. chromecast/
  12. chromeos/
  13. codelabs/
  14. components/
  15. content/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. gpu/
  25. headless/
  26. infra/
  27. ios/
  28. ipc/
  29. media/
  30. mojo/
  31. native_client_sdk/
  32. net/
  33. pdf/
  34. ppapi/
  35. printing/
  36. remoting/
  37. rlz/
  38. sandbox/
  39. services/
  40. skia/
  41. sql/
  42. storage/
  43. styleguide/
  44. testing/
  45. third_party/
  46. tools/
  47. ui/
  48. url/
  49. webkit/
  50. clank
  51. internal
  52. ios_internal
  53. signing_keys
  54. v8
  55. .clang-format
  56. .clang-tidy
  57. .clangd
  58. .cursorignore
  59. .git-blame-ignore-revs
  60. .gitallowed
  61. .gitattributes
  62. .gitignore
  63. .gitmodules
  64. .gn
  65. .mailmap
  66. .rustfmt.toml
  67. .vpython3
  68. .yapfignore
  69. ATL_OWNERS
  70. AUTHORS
  71. BUILD.gn
  72. CODE_OF_CONDUCT.md
  73. codereview.settings
  74. CPPLINT.cfg
  75. CRYPTO_OWNERS
  76. DEPS
  77. DIR_METADATA
  78. LICENSE
  79. LICENSE.chromium_os
  80. OWNERS
  81. PRESUBMIT.py
  82. PRESUBMIT_test.py
  83. PRESUBMIT_test_mocks.py
  84. README.md
  85. SECURITY_OWNERS
  86. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.