commit | cc583ecfeea6f072fd7f23786fa59fded6e4fe23 | [log] [tgz] |
---|---|---|
author | Howard Yang <hcyang@google.com> | Fri Dec 20 02:59:05 2024 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Dec 20 02:59:05 2024 |
tree | 9272ac11def23ec6958ac3517b4b2e12d8d73e83 | |
parent | 3c32b25b56906990854b304f0da4ac57f990dc12 [diff] |
[CORAL] Cache embeddings when load state changed Currently embeddings are only cached when title or source changed. But embeddings are NOT cached when the tab is still loading. So if a tab is still loading but actually its title or source won't change anymore, it won't be cached ever. Update logic to cache if load state changes too. Bug: chromium:385079935 Test: CQ Change-Id: I29160b2b8fe60af0c66276afc0a23d7212bd0df1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6108646 Commit-Queue: Howard Yang <hcyang@google.com> Reviewed-by: Xiaodan Zhu <zxdan@chromium.org> Cr-Commit-Position: refs/heads/main@{#1398995}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.