commit | cc717819117cd9be07addac29caed2dd8fd7acb9 | [log] [tgz] |
---|---|---|
author | Jonathan Lee <jonathanjlee@google.com> | Fri Jan 27 19:15:06 2023 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Jan 27 19:15:06 2023 |
tree | ce4d781a5a0fd8b1a5e1b340e83a5ac9d805b00e | |
parent | d268c047d8937036fde3ab27d8240dd80f8cdf2c [diff] |
Revert "VT: Require a documentElement for the transition to happen" This reverts commit 39f8928063ad59b8e711e6c506988749067e3e3b. Reason for revert: Added test is failing on "Linux Tests" on a virtual suite: https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Tests/125697/overview Original change's description: > VT: Require a documentElement for the transition to happen > > This patch ensures that we don't start a transition if we don't > have a document element. This is because documentElement is the > originating element for the pseudo tree, so we need to have it > for the transition to happen. > > Note that if we want to support documents that don't have a > documentElement, then we need to figure out where to put the > pseudo elements. > > R=​khushalsagar@chromium.org > > Fixed: 1410435 > Change-Id: Ib380e87dba2986ace6a567f37ff2cfa5b30268ec > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4198955 > Reviewed-by: Khushal Sagar <khushalsagar@chromium.org> > Commit-Queue: Khushal Sagar <khushalsagar@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1097990} Change-Id: I4951a882eb0ea758eff2d27f6ed531c9c303c96a No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4199443 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Jonathan Lee <jonathanjlee@google.com> Owners-Override: Jonathan Lee <jonathanjlee@google.com> Cr-Commit-Position: refs/heads/main@{#1098039}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.