Google Git
Sign in
chromium / chromium / src / cc7b6422a2c82f2e742af34c9519fee21ed38b51
commitcc7b6422a2c82f2e742af34c9519fee21ed38b51[log] [tgz]
authorErnest Nguyen Hung <ernn@google.com>Wed Jun 04 15:38:43 2025
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Jun 04 15:38:43 2025
treed000ccc94a500f9884904b993eaab18364863fd2
parent5ba2dcdd9d34df9b9a06e6b00f7711e79163f358 [diff]
[Profiles] Fix layout insets calculation for avatar toolbar button

`ToolbarButton::SetHighlight` may NOT clear the text immediately (it is
delayed until the size is changed, see
https://source.chromium.org/chromium/chromium/src/+/main:ui/views/controls/button/label_button.cc;l=332;drc=5318c4f11b274b13e333d54086ec1bfccdaea197).
On the other hand, `AvatarToolbarButton::IsLabelPresentAndVisible`
checks whether the text is empty. Calling it right after
`ToolbarButton::SetHighlight` might lead to subtle bugs and incorrect
layout insets as in the bug demonstrated below (recordings are internal
only):

Before:
https://screencast.googleplex.com/cast/NjIxNzI2NjE1MTU1NTA3MnxjZTk4NWEzNi1hMQ

After:
https://screencast.googleplex.com/cast/NjA4NzU3MTA5MTIyNjYyNHwyOGNjOTE3Zi0zOA

This started occurring after crrev.com/c/6607244 (because passing no
text and no background triggers the delay logic, see
https://source.chromium.org/chromium/chromium/src/+/main:chrome/browser/ui/views/toolbar/toolbar_button.cc;l=134;drc=7bb2f459f122ae9c3c3d46a443f85e67ca9f6754.

Bug: 422384304
Change-Id: Id4b99dc962451e8b0f254b1012addc0b941aed0e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6621062
Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Ernest Nguyen Hung <ernn@google.com>
Cr-Commit-Position: refs/heads/main@{#1469313}
2 files changed
tree: d000ccc94a500f9884904b993eaab18364863fd2
  1. .github/
  2. android_webview/
  3. apps/
  4. ash/
  5. base/
  6. build/
  7. build_overrides/
  8. buildtools/
  9. cc/
  10. chrome/
  11. chromecast/
  12. chromeos/
  13. codelabs/
  14. components/
  15. content/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. gpu/
  25. headless/
  26. infra/
  27. ios/
  28. ipc/
  29. media/
  30. mojo/
  31. native_client_sdk/
  32. net/
  33. pdf/
  34. ppapi/
  35. printing/
  36. remoting/
  37. rlz/
  38. sandbox/
  39. services/
  40. skia/
  41. sql/
  42. storage/
  43. styleguide/
  44. testing/
  45. third_party/
  46. tools/
  47. ui/
  48. url/
  49. webkit/
  50. clank
  51. internal
  52. ios_internal
  53. native_client
  54. signing_keys
  55. v8
  56. .clang-format
  57. .clang-tidy
  58. .clangd
  59. .git-blame-ignore-revs
  60. .gitallowed
  61. .gitattributes
  62. .gitignore
  63. .gitmodules
  64. .gn
  65. .mailmap
  66. .rustfmt.toml
  67. .vpython3
  68. .yapfignore
  69. ATL_OWNERS
  70. AUTHORS
  71. BUILD.gn
  72. CODE_OF_CONDUCT.md
  73. codereview.settings
  74. CPPLINT.cfg
  75. CRYPTO_OWNERS
  76. DEPS
  77. DIR_METADATA
  78. LICENSE
  79. LICENSE.chromium_os
  80. OWNERS
  81. PRESUBMIT.py
  82. PRESUBMIT_test.py
  83. PRESUBMIT_test_mocks.py
  84. README.md
  85. SECURITY_OWNERS
  86. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.