Google Git
Sign in
chromium / chromium / src / cc7d2e3b98130cc602bed197552aaaa5873b51e5
commitcc7d2e3b98130cc602bed197552aaaa5873b51e5[log] [tgz]
authorBenjamin Williams <bwwilliams@google.com>Thu Feb 06 09:54:03 2025
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Feb 06 09:54:03 2025
tree16da71f1bf093fcefd868528e827cb9a12f79f65
parent95d1cf9a4e60a27f834178e8b75e750ecba3122f [diff]
[iOS] Conditionally highlight the "Set a reminder" overflow menu action

This CL introduces functionality to conditionally highlight the "Set a
Reminder" action in the overflow menu based on user interaction with its
corresponding in-product help (IPH) bubble. If a user interacts with the
IPH bubble for Tab Reminders, the "Set a Reminder" action will be
highlighted to reinforce the connection between the IPH and the feature
it promotes.

Demo Videos:

When the user successfully completes the IPH flow:
https://drive.google.com/file/d/1q2nX9Lt7-4IQ6_0QODTFwQuiXuVELBWK/view?usp=drive_link&resourcekey=0-lmRo-SGR_POOg0guJsIifw

When the IPH bubble expires:
https://drive.google.com/file/d/1qWD0FhbKjjqBassdtrno7i-WYVAjyvGT/view?usp=drive_link&resourcekey=0-X_CQ6Md8nmfZTMCaYx7TQQ

When the user taps away from the IPH bubble:
https://drive.google.com/file/d/1RsBZQUB0sdRbylU-SG0X93PkImMawalQ/view?usp=drive_link&resourcekey=0-pZnOE0H6XMEgTBx6uWzBvw

Change-Id: Iaa98a3f61f846ea3199e566d8410e003d8b7063a
Fixed: 389912241
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6226549
Reviewed-by: Robbie Gibson <rkgibson@google.com>
Commit-Queue: Mark Cogan <marq@chromium.org>
Auto-Submit: Benjamin Williams <bwwilliams@google.com>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1416670}
1 file changed
tree: 16da71f1bf093fcefd868528e827cb9a12f79f65
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. gpu/
  24. headless/
  25. infra/
  26. ios/
  27. ipc/
  28. media/
  29. mojo/
  30. native_client_sdk/
  31. net/
  32. pdf/
  33. ppapi/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. clank
  50. internal
  51. ios_internal
  52. native_client
  53. signing_keys
  54. v8
  55. .clang-format
  56. .clang-tidy
  57. .clangd
  58. .git-blame-ignore-revs
  59. .gitallowed
  60. .gitattributes
  61. .gitignore
  62. .gitmodules
  63. .gn
  64. .mailmap
  65. .rustfmt.toml
  66. .vpython3
  67. .yapfignore
  68. ATL_OWNERS
  69. AUTHORS
  70. BUILD.gn
  71. CODE_OF_CONDUCT.md
  72. codereview.settings
  73. CPPLINT.cfg
  74. CRYPTO_OWNERS
  75. DEPS
  76. DIR_METADATA
  77. LICENSE
  78. LICENSE.chromium_os
  79. OWNERS
  80. PRESUBMIT.py
  81. PRESUBMIT_test.py
  82. PRESUBMIT_test_mocks.py
  83. README.md
  84. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.