Google Git
Sign in
chromium / chromium / src / cc7df5f223b1372d7d0a6262315d27f8c53557ed
commitcc7df5f223b1372d7d0a6262315d27f8c53557ed[log] [tgz]
authorBrad Triebwasser <btriebw@chromium.org>Thu Sep 19 20:00:01 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Sep 19 20:00:01 2024
tree481da52587d1cc09bc134b8efe70e163e42fb0a8
parentfe446640a4cc54533ba91b2a415b3cdbfe61344b [diff]
Reland "Remove display id in VirtualDisplayUtil::AddDisplay."

This is a reland of commit 557a678e03118da342b0b98c75932901857314ee

Serial numbers need to start at one on mac. A serial number of 0 was causing a crash.

Original change's description:
> Remove display id in VirtualDisplayUtil::AddDisplay.
>
> Removes the ability for callers to specify a display ID on
> VirtualDisplayUtil::AddDisplay. Most platforms (except for Mac) cannot
> influence the resulting display::Screen id. Instead, each virtual
> display controller maintains its own internal ids.
>
>
> Bug: 40271794
> Change-Id: If8707c2ed4ae98e59ea831f43e7fdd28797a1c3f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5840551
> Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
> Commit-Queue: Brad Triebwasser <btriebw@chromium.org>
> Reviewed-by: Mike Wasserman <msw@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1356226}

Bug: 40271794
Change-Id: Ia6127882163faf7db7082570a3d77df0d07da71a
Include-Ci-Only-Tests: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5870624
Reviewed-by: Mike Wasserman <msw@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Brad Triebwasser <btriebw@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1357809}
16 files changed
tree: 481da52587d1cc09bc134b8efe70e163e42fb0a8
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. google_update/
  24. gpu/
  25. headless/
  26. infra/
  27. ios/
  28. ipc/
  29. media/
  30. mojo/
  31. native_client_sdk/
  32. net/
  33. pdf/
  34. ppapi/
  35. printing/
  36. remoting/
  37. rlz/
  38. sandbox/
  39. services/
  40. skia/
  41. sql/
  42. storage/
  43. styleguide/
  44. testing/
  45. third_party/
  46. tools/
  47. ui/
  48. url/
  49. webkit/
  50. clank
  51. internal
  52. ios_internal
  53. native_client
  54. signing_keys
  55. v8
  56. .clang-format
  57. .clang-tidy
  58. .clangd
  59. .eslintrc.js
  60. .git-blame-ignore-revs
  61. .gitallowed
  62. .gitattributes
  63. .gitignore
  64. .gitmodules
  65. .gn
  66. .mailmap
  67. .rustfmt.toml
  68. .vpython3
  69. .yapfignore
  70. ATL_OWNERS
  71. AUTHORS
  72. BUILD.gn
  73. CODE_OF_CONDUCT.md
  74. codereview.settings
  75. CPPLINT.cfg
  76. CRYPTO_OWNERS
  77. DEPS
  78. DIR_METADATA
  79. LICENSE
  80. LICENSE.chromium_os
  81. OWNERS
  82. PRESUBMIT.py
  83. PRESUBMIT_test.py
  84. PRESUBMIT_test_mocks.py
  85. README.md
  86. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.