commit | ccdbd4ce097bf56a2ae5a65f9d77c56f2a61ee7c | [log] [tgz] |
---|---|---|
author | Katie Dektar <katie@chromium.org> | Mon Aug 08 21:14:02 2022 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Aug 08 21:14:02 2022 |
tree | a706ce00bbe2525c4d7daafdcefa0c3c69dc32cd | |
parent | c5b1705d53836a2bc9a6c6bc8bce01edbf2e0af9 [diff] |
[Sheriff] Revert "SET: Propagate the callback error to the caller / devtools." This reverts commit 169c59eea4ed4384f76bc671c5813554f5de7ae5. Reason for revert: Seems to have caused test failures: https://ci.chromium.org/ui/p/chromium/builders/ci/WebKit%20Linux%20Leak/41422/test-results by adding unexpected console errors: +CONSOLE ERROR: Uncaught (in promise) AbortError: Aborted due to failure in DocumentTransitionCallback Original owner is out for the day so speculatively reverting to reduce failures until fix can be made later. Original change's description: > SET: Propagate the callback error to the caller / devtools. > > This patch propagates the error up from the callback. Without this > patch we just know that an exception happened in a promise, but with > this we actually know what the error is, which makes it easier to > debug callbacks. > > R=​khushalsagar@chromium.org > > Change-Id: I85a70f613e01fb1206365e7460edb805edd5fe53 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3807891 > Reviewed-by: Khushal Sagar <khushalsagar@chromium.org> > Commit-Queue: Vladimir Levin <vmpstr@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1032649} Change-Id: I783551933525b0fe415a40d9a58d09840186975f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1351145 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3816825 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Owners-Override: Katie Dektar <katie@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/main@{#1032728}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.