growth: Fix dangling pointer in notification Here is what happened: 1. Pass the `params` as a raw pointer to the notification. The raw pointer is a dictionary pointer in memory. 2. Lock the device. 3. Unlock the device, we replace the dictionary. The pointer became dangling. 4. Users click the notification, uses the dangling pointer. We will fix this by passing a dictionary value to the callbacks. Bug: 389453140 Test: added new tests and manually tested Change-Id: If1ff0b2672e121a9dc6e71ea530abb194f00359f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6181795 Reviewed-by: Li Lin <llin@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/main@{#1409431}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.