Revert "Get ContentAutofillDriverFactory::DidFinishNavigation early return back." This reverts commit e957c5e67218403ebfee98dffcc7e568e479b8d7. Reason for revert: The CL was landed for temp experimentation, the hypothesis of the "Autofill.Funnel.ParsedAsType.*" metrics drop reason was proofed and the CL can be reverted Original change's description: > Get ContentAutofillDriverFactory::DidFinishNavigation early return back. > > crrev.com/c/4896011 removed an early return > `ContentAutofillDriverFactory::DidFinishNavigation`. > > We believe that this was the root cause of a change in our metrics. > The purpose of this CL is to temporarily bring the lines back to > verify the hypothesis. Once verified, the temporary lines will be > removed again. > > We believe that `driver->Reset()` at the end of > `ContentAutofillDriverFactory::DidFinishNavigation` led to resetting > the metric instance variable and that this caused to a change in the > number of submitted samples, which affected metrics of not-submitted > Address and Credit Card forms. > > Bug: 1492636 > Change-Id: I9e2175f0480f762a418392a94259da1f142722ce > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5014086 > Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com> > Reviewed-by: Christoph Schwering <schwering@google.com> > Reviewed-by: Dominic Battre <battre@chromium.org> > Commit-Queue: Dmitry Vykochko <vykochko@google.com> > Cr-Commit-Position: refs/heads/main@{#1224822} Bug: 1492636 Change-Id: Idea933bb3f8a04b9c9024c9d6441f4e2e43dab76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5104775 Commit-Queue: Dmitry Vykochko <vykochko@google.com> Reviewed-by: Dominic Battre <battre@chromium.org> Cr-Commit-Position: refs/heads/main@{#1238666}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.