Google Git
Sign in
chromium / chromium / src / cd6247b58fc31d7351bf823f145e9ff04e33555f
commitcd6247b58fc31d7351bf823f145e9ff04e33555f[log] [tgz]
authorJérôme Lebel <jlebel@chromium.org>Fri Sep 05 13:37:57 2025
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Sep 05 13:37:57 2025
treef7575560fb8839a89f18d270c7b0d68936585a8b
parentc8f931506c4b27d089ac101052fec28d1e825fc4 [diff]
[iOS] Avoid reentry in add account coordinator

It is unclear how it possible, but while there is a way to have a
stack of coordinator, the user is able to sign-in using another UI:
- SigninAndHistorySyncCoordinator
- InstantSigninCoordinator
- AddAccountSigninCoordinator

In the bug, AddAccountSigninCoordinator is stuck by displaying the
alert dialog (to say that it is not possible to open to add account
at the same time).

Since the primary account is set, InstantSigninCoordinator stops itself
and shutdown AddAccountSigninCoordinator. While the add account
coordinator stops, it also stops the alert dialog.
By stopping the alert dialog, this triggers a second stop of the add
account coordinator.

To avoid a reentry, when before stopping the alert dialog,
`alertCoordinator.noInteractionAction` needs to be set to nil.

This patch should be cherry-picked in M141, and maybe in M140.

Fixed: 441677851
Change-Id: I6511ea7c447d853a5e578e1d6dfd36106b2d1fa8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6917619
Auto-Submit: Jérôme Lebel <jlebel@chromium.org>
Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1511520}
1 file changed
tree: f7575560fb8839a89f18d270c7b0d68936585a8b
  1. .gemini/
  2. .github/
  3. agents/
  4. android_webview/
  5. apps/
  6. ash/
  7. base/
  8. build/
  9. build_overrides/
  10. buildtools/
  11. cc/
  12. chrome/
  13. chromecast/
  14. chromeos/
  15. codelabs/
  16. components/
  17. content/
  18. crypto/
  19. dbus/
  20. device/
  21. docs/
  22. extensions/
  23. fuchsia_web/
  24. gin/
  25. google_apis/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. media/
  32. mojo/
  33. net/
  34. pdf/
  35. printing/
  36. remoting/
  37. rlz/
  38. sandbox/
  39. services/
  40. skia/
  41. sql/
  42. storage/
  43. styleguide/
  44. testing/
  45. third_party/
  46. tools/
  47. ui/
  48. url/
  49. webkit/
  50. clank
  51. clusterfuzz-data
  52. internal
  53. ios_internal
  54. signing_keys
  55. v8
  56. .clang-format
  57. .clang-tidy
  58. .clangd
  59. .cursorignore
  60. .geminiignore
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. CPPLINT.cfg
  77. CRYPTO_OWNERS
  78. DEPS
  79. DIR_METADATA
  80. LICENSE
  81. LICENSE.chromium_os
  82. OWNERS
  83. PRESUBMIT.py
  84. PRESUBMIT_test.py
  85. PRESUBMIT_test_mocks.py
  86. README.md
  87. SECURITY_OWNERS
  88. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.