commit | edab3f876efd5ba2c5b71ab16154f22cdb30edf0 | [log] [tgz] |
---|---|---|
author | Daniel Cheng <dcheng@chromium.org> | Sat Oct 01 03:31:37 2022 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Sat Oct 01 03:31:37 2022 |
tree | be45a516ec86b813ca296507d9808af25e519a7d | |
parent | b30977a4240d26e6f1eabfa83eed8a09564ddad8 [diff] |
Use helper macros to define base::Features in //crypto This allows: - features to be defined with a consistent set of qualifiers, and for that set of qualifiers to be updated over time as appropriate. - better PRESUBMIT checks to ensure that base::Features are not defined in headers. - simplifies things for scripts trying to extract feature definitions out of C++ code. The primary CL was generated using a script that automatically rewrites base::Feature declarations and definitions to the macro form. Changes to any files with known incompatibilities with the macros (base::Features without static storage duration and base::Features declared as static class members) were then fully reverted; those changes will be manually handled in followups. This is a manual cleanup pass to fix up a straggler that needed an additional static specifier. Bug: 1364289 Change-Id: I9adcf30239f2c4d82f5ad1a9d5ab47cbade73a15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3931425 Commit-Queue: Lei Zhang <thestig@chromium.org> Owners-Override: Lei Zhang <thestig@chromium.org> Auto-Submit: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/main@{#1053882}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.