Google Git
Sign in
chromium / chromium / src / cda33891059f23043eeed87081073c97ae2b325f
commitcda33891059f23043eeed87081073c97ae2b325f[log] [tgz]
authorSiyu An <siyua@chromium.org>Wed Sep 14 22:57:17 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Sep 14 22:57:17 2022
tree21101b379f20bd3fa12d689c3974387a089ec846
parentced6a8ebdaad78a8efb10c561ee11aa123e9415a [diff]
Reland "[Metadata] Show card network icon in the chrome settings page"

This is a reland of commit 442ea0a644962b9d6440da95e4c19cae6773046a

CL was reverted due to breaking https://ci.chromium.org/ui/p/chromium/builders/ci/Win7%20(32)%20Tests/84813/overview.

Suspecting it due to image rendering on Win7? Patchset2 change it back
to check whether the element is hidden

Original change's description:
> [Metadata] Show card network icon in the chrome settings page
>
> This refers to only the network icon at the beginning of the each row.
>
> Before: https://screenshot.googleplex.com/BHPZKZjxAKCx2BL
> After: https://screenshot.googleplex.com/6hiSXamLcvQYcUh
> Mock: https://screenshot.googleplex.com/45jawPduaAdTWqV
>
> Bug: 1313616
> Change-Id: I3c353971ee466f2c71df5b42e05cb9df8cb1adf5
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3852627
> Commit-Queue: Siyu An <siyua@chromium.org>
> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
> Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1042325}

Bug: 1313616
Change-Id: I3d02e7f405ef58188b5557a0208ff1f9070f3aae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3881703
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Siyu An <siyua@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1047167}
7 files changed
tree: 21101b379f20bd3fa12d689c3974387a089ec846
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython
  61. .vpython3
  62. .yapfignore
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. ENG_REVIEW_OWNERS
  70. LICENSE
  71. LICENSE.chromium_os
  72. OWNERS
  73. PRESUBMIT.py
  74. PRESUBMIT_test.py
  75. PRESUBMIT_test_mocks.py
  76. README.md
  77. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.