Google Git
Sign in
chromium / chromium / src / cdc61d2e615a4621beb80703e7ed83a35d5e5a18
commitcdc61d2e615a4621beb80703e7ed83a35d5e5a18[log] [tgz]
authorMaxim Anufriev <maxan@google.com>Tue Jun 14 14:32:47 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue Jun 14 14:32:47 2022
tree08b8ff11ad06483ec3ed4cf9c7fef809fdf293f7
parent436e78adbc0512d042ec208085b8c476f0476d61 [diff]
[M103][Fix] Handle password backend errors on non-android platforms.

Fix the crash caused by incorrectly handling PasswordStore backend
error on non-Android platforms.
Empty changelist was used to indicate errors here and should not be
replaced by the absl::nullopt which is used on Andorid to indicate a
success operation with inability to fetch its result.

There is a tracking bug for explicit error handling: crbug.com/1321051

(cherry picked from commit 93fc637528577acb269e0d26d96bd19eca6fa7b2)

Bug: 1335681
Change-Id: Ia06bba841e584c5ce94ac6f80c42769dfbc3cd2d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3702374
Commit-Queue: Maxim Anufriev <maxan@google.com>
Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
Reviewed-by: Friedrich Horschig <fhorschig@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1013415}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3705207
Cr-Commit-Position: refs/branch-heads/5060@{#826}
Cr-Branched-From: b83393d0f4038aeaf67f970a024d8101df7348d1-refs/heads/main@{#1002911}
3 files changed
tree: 08b8ff11ad06483ec3ed4cf9c7fef809fdf293f7
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. fuchsia_webengine/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .mailmap
  60. .rustfmt.toml
  61. .vpython
  62. .vpython3
  63. .yapfignore
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. ENG_REVIEW_OWNERS
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.