media/chromeos/VDPipeline: Make FrameResourceConverter output VideoFrames

At the end of VideoDecoderPipeline a VideoFrame needs to be produced.
This was happening in OnFrameConverted. However, all implementations of
FrameResourceConverter were producing a VideoFrameResource, which were
being unwrapped in OnFrameConverted.

This changes FrameResourceConverter to output VideoFrames instead of
VideoFrameResources. VideoDecoderPipeline::OnFrameConverted() now
accepts a VideoFrame. The VideoFrame conversion code in
OnFrameConverted() has been moved into a new FrameResourceConverter
class, DefaultFrameConverter.

DefaultFrameConverter is used by VideoDecoderPipeline when a client does
not specify a converter. It uses the built-in FrameResource methods to
convert a FrameResource to a VideoFrame. VideoDecoderPipeline also drops
its support of NULL |frame_converter_| since it is guaranteed to be set.

UsesGetOriginalFrameCB() was added to FrameResourceConverter as a way
for VideoDecoderPipeline to determine whether or not it needs to use
set_get_original_frame_cb(). This fixes unit tests where the frame pool
is expected to be a PlatformVideoFramePool.

Bug: b:332382416
Change-Id: Ic78869ae287fe46654bb7d7fb046d494ed404fd5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5632235
Commit-Queue: Nathan Hebert <nhebert@chromium.org>
Reviewed-by: Andres Calderon Jaramillo <andrescj@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1319549}
8 files changed
tree: c36d500ad87a3185d7ef8551b8d8527f2cc80804
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. .clang-format
  52. .clang-tidy
  53. .clangd
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitallowed
  57. .gitattributes
  58. .gitignore
  59. .gitmodules
  60. .gn
  61. .mailmap
  62. .rustfmt.toml
  63. .vpython3
  64. .yapfignore
  65. ATL_OWNERS
  66. AUTHORS
  67. BUILD.gn
  68. CODE_OF_CONDUCT.md
  69. codereview.settings
  70. CPPLINT.cfg
  71. DEPS
  72. DIR_METADATA
  73. LICENSE
  74. LICENSE.chromium_os
  75. OWNERS
  76. PRESUBMIT.py
  77. PRESUBMIT_test.py
  78. PRESUBMIT_test_mocks.py
  79. README.md
  80. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.