spanify: Fix a bug for rewriting x => !x.empty() When rewriting an implicit conversion from `x` to a boolean, we're rewriting it to `!x.empty()`. But the previous patch https://crrev.com/c/6280526 was wrong about the position to insert `!` in case of a macro, e.g. MACRO(x). It inserts `!` into a macro definition despite that `!` should be inserted before `x` on the call sites. New test cases excersise the regression cases. Bug: 397043083, 358306232 Change-Id: I4cdbc7255986e110204408eaaf724cea07797467 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6332463 Reviewed-by: Keishi Hattori <keishi@chromium.org> Reviewed-by: Stephen Nusko <nuskos@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/main@{#1431341}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.