Google Git
Sign in
chromium / chromium / src / ce4576b1574c88f65248ec337067bb92208114a1
commitce4576b1574c88f65248ec337067bb92208114a1[log] [tgz]
authorSaifuddin Hitawala <hitawala@chromium.org>Thu Dec 01 02:06:29 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Dec 01 02:06:29 2022
tree2d19060cc03b8542adc7aa4c0e672a67d735d037
parentd8dc9835e6aeea63b9026139406e7bfe1c37b8a1 [diff]
Multiplanar: Add external sampler support to SkiaGLImageRep

Currently when creating shared images with legacy multiplanar formats
eg. ResourceFormat::YUV_420_BIPLANAR, the planes are passed
individually as BufferPlane::Y, UV in which cases there is a shared
image per plane. Clients can also pass BufferPlane::DEFAULT in which
there is one shared image and it is assumed that client wants to use
external sampler for reads.

With multiplanar SharedImageFormats, we keep the check for external
sampler and accordingly create a single texture for the format.
This change adds the missing external sampler support while creating
promise textures for SkiaGLImageRepresentation.

Bug: 1366481
Change-Id: I054d52cb0691aadafdaca5b2f084836017e7d933
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4062758
Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Commit-Queue: Saifuddin Hitawala <hitawala@chromium.org>
Reviewed-by: Kyle Charbonneau <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1077764}
1 file changed
tree: 2d19060cc03b8542adc7aa4c0e672a67d735d037
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. AUTHORS
  63. BUILD.gn
  64. CODE_OF_CONDUCT.md
  65. codereview.settings
  66. DEPS
  67. DIR_METADATA
  68. ENG_REVIEW_OWNERS
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.