commit | ce4d63c12d16f33cead60852bc256a8e5fdebed5 | [log] [tgz] |
---|---|---|
author | Justin Lulejian <jlulejian@chromium.org> | Wed Oct 09 23:14:11 2024 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Oct 09 23:14:11 2024 |
tree | a7d077567ad1a5edf627cbbaf9e997cba01e5d3e | |
parent | 13a9942b0bd4402b49e50f1bfabe0d88b5fd118e [diff] |
[Extensions] Create message delivery tracker class. Message delivery appears to be failing in some stages of the message process because sometimes the caller never gets a response from the background context (specifically service workers). To scope down where in the process the issue might be occurring I created this class to help coordinate the tracking of the message. The tracker will monitor message progress through key stages and emits success/failure metrics. This will help pinpoint potential issues in the message delivery process. It allows a caller (in the browser) to call this singleton as the message is observed to pass through each stage. It is not specific to workers to allow for comparison between background types. The general flow of a call is: 1) NotifyStartTrackingMessageDelivery() to start tracking a message to its background context 2) NotifyUpdateMessageDelivery() each time when the next stage in message delivery has been reached 3) NotifyStopTrackingMessageDelivery() to stop tracking the message when it has been deemed as *successfully delivered to the background context (which emits success metrics) Starting and updating message delivery will result in a delayed task (NotifyStaleMessage()) that is called 30 seconds later. 30 seconds was determined arbitrarily. If the message is still being tracked at this point it is considered stale/unsuccessful and failure metrics will be emitted. *Successful can be defined differently depending on if the caller expects a response or not since expecting a response would track the later response stages back to the caller, whereas not expecting a response wouldn't need to track those later stages. Bug: 371011217 Change-Id: I1d02837fb6dcccec3a56fb4cc6b1a5974087a180 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5906729 Auto-Submit: Justin Lulejian <jlulejian@chromium.org> Reviewed-by: Emilia Paz <emiliapaz@chromium.org> Commit-Queue: Justin Lulejian <jlulejian@chromium.org> Cr-Commit-Position: refs/heads/main@{#1366516}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.