commit | ce994680cbb04fe28aeb3060d74f294e827df8b3 | [log] [tgz] |
---|---|---|
author | Sam Goto <goto@chromium.org> | Tue Apr 29 14:09:56 2025 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue Apr 29 14:09:56 2025 |
tree | b327cce814644ac32583aab77fe25f60cff699c4 | |
parent | de95e18a4cfcea522ed0887c8faee181d31c402f [diff] |
[fedcm] Autofill emails only if the user accepts the modal dialog prompt For verified email addresses, we'll show the FedCM modal dialog to get some confirmation that the user wants to share their email address (along with other fields, such as names and profile pictures). When the modal dialog is shown, the user has the choice to reject or dismiss it. When that happens, we want to make sure that the field does not get auto-filled (in addition to failing the promise of the conditional request). For the password field recommendation, on the other hand, a modal isn't necessary, and the token can be auto-granted without requiring extra prompting. To accomplish these differences, we introduce: - A boolean parameter to OnFederatedTokenReceivedCallback, to let the browser and password autofill managers know if the request succeeded - A boolean autogrant parameter to NotifyAutofillSuggestionAccepted to let the FederatedAuthAutofillSource know whether to request additional permission or not And the necessary implementation in the FederatedAuthAutofillSource to accomplish the semantics described above. Bug: 380367784 Change-Id: I8f5bf5d75738ad0f6e1d2545ecc8f2697cfe8806 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6484645 Commit-Queue: Sam Goto <goto@chromium.org> Auto-Submit: Sam Goto <goto@chromium.org> Reviewed-by: Jihad Hanna <jihadghanna@google.com> Cr-Commit-Position: refs/heads/main@{#1453194}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.