Google Git
Sign in
chromium / chromium / src / cecaed60b19d2df9d086012a0f6bb181c8d53e4c
commitcecaed60b19d2df9d086012a0f6bb181c8d53e4c[log] [tgz]
authorMinju Kim <mkim@igalia.com>Wed Jan 24 20:23:04 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Jan 24 20:23:04 2024
tree76da472820521121de5f2adc9d05f9a692284ceb
parenta6c2dd2fefd714b8928b8ec2514fdf01c0111fb8 [diff]
[iOS blink] Aligning text decoration style and color for spelling
and grammar error with MacPort.

In 'paint/markers' web platform tests, we observed differences
in the style and color of text decorations for spelling and
grammar error between iOS and MacPort.
MacPort uses a red-dotted underline and a green-dotted underline
for these errors,
while iOSPort currently uses LayoutTheme colors (bright red/grey)
with a wavy style. [1][2]
Therefore, this CL updates iOSPort to adopt the same style and color
as used in MacPort.

[1] https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/layout/layout_theme.cc;drc=00194f3c72faa8dbd9e8e6fff05f82ce86019468;l=347
[2] https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/layout/layout_theme.cc;drc=00194f3c72faa8dbd9e8e6fff05f82ce86019468;l=351

Bug: 1421239
Change-Id: I7ef87588bb9a5e2f869c0fca702fd64848fb1df7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5227640
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Ian Vollick <vollick@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1251637}
4 files changed
tree: 76da472820521121de5f2adc9d05f9a692284ceb
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. DEPS
  77. DIR_METADATA
  78. LICENSE
  79. LICENSE.chromium_os
  80. OWNERS
  81. PRESUBMIT.py
  82. PRESUBMIT_test.py
  83. PRESUBMIT_test_mocks.py
  84. README.md
  85. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.