ScriptId should only be requested from source text modules V8 triggers a fatal error when requesting ScriptId on a non source text module. Add similar protection when tracing as is done further up in this function when evaluating the module. The fatal error was hit in some cases when importing synthetic modules (like JSON modules) while collecting performance trace data via devtools. Bug: 417673004 Change-Id: I7564d97b0491dade7ddb6e6795ee3eb43cce768f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6545988 Reviewed-by: Alex Rudenko <alexrudenko@chromium.org> Reviewed-by: Simon Zünd <szuend@chromium.org> Auto-Submit: Roger Johannesson <roger.johannesson@xperi.com> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#1461223}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.