Google Git
Sign in
chromium / chromium / src / ceff1b0531e34f358eca07ec8238a8f9b5321e3a
commitceff1b0531e34f358eca07ec8238a8f9b5321e3a[log] [tgz]
authorNick Diego Yamane <nickdiego@igalia.com>Fri Apr 22 23:54:03 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Apr 22 23:54:03 2022
tree8c9e6df2b879cd0266ffa3ba5d58f11ef1fb04f4
parent2a54463e3b7664c7b85ebd360982d6dc3a85999b [diff]
[M102] wayland: harden window pointers manipulation in window drag controller

There is no guarantees that windows manipulated by Ozone Wayland's
window drag controller will keep alive until the drag session ends. A
good example is a webapp using window.close() API to programmatically
close the browser window.

That said, this CL gets rid of some related assumptions in drag
controller's code, hardening it against UaFs and other potential memory
corruption / security issues. Unit tests are added to exercise these
scenarios.

R=​tonikitoo@igalia.com

(cherry picked from commit 82f327eebcf881b17dec0e6edeb9bda87facd859)

Bug: 1308968
Test: Covered by ozone_unittests
Change-Id: I1cf98c65d458fcbdaa5170454c119c4c42af2571
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3580853
Reviewed-by: Antonio Gomes <tonikitoo@igalia.com>
Commit-Queue: Nick Yamane <nickdiego@igalia.com>
Cr-Original-Commit-Position: refs/heads/main@{#993844}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3602559
Auto-Submit: Nick Yamane <nickdiego@igalia.com>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5005@{#121}
Cr-Branched-From: 5b4d9450fee01f821b6400e947b3839727643a71-refs/heads/main@{#992738}
3 files changed
tree: 8c9e6df2b879cd0266ffa3ba5d58f11ef1fb04f4
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython
  61. .vpython3
  62. .yapfignore
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. ENG_REVIEW_OWNERS
  70. LICENSE
  71. LICENSE.chromium_os
  72. OWNERS
  73. PRESUBMIT.py
  74. PRESUBMIT_test.py
  75. PRESUBMIT_test_mocks.py
  76. README.md
  77. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.