commit cf05e84b69d899dd0530d953fe2b1cb947390dd8
author Daniel Bratell <bratell@opera.com> Wed Mar 13 07:07:50 2019
committer Commit Bot <commit-bot@chromium.org> Wed Mar 13 07:07:50 2019
tree 521c9b98bdfed02b7df9d500ef88d280ba99d2d1
parent c9819b64456f0917baa4be9ceeec100e0f7a8619

Don't emit RevocableInterfacePtr in mojo's blink bindings

The code that we emit in mojo's blink bindings are sometimes
loaded into non-blink code (see bug) and from there you should not
access code inside blink. Since RevocableInterfacePtr lives inside
blink, that causes dependency and layering violations.

Everyone using blink bindings got something similar to.
ERROR at //out/Default/gen/components/content_settings/core/common/content_settings.mojom-blink-forward.h:20:11: Include not allowed.
#include "third_party/blink/renderer/platform/mojo/revocable_interface_ptr.h"
          ^-----------------------------------------------------------------
It is not in any dependency of
  //components/content_settings/core/common:mojo_bindings_blink
The include file is in the target(s):
  //third_party/blink/renderer/platform:platform
which should somehow be reachable.
___________________

In total there were about 1000 reported dependency errors
because of this.

This fixes this by inlining the few uses and removing the includes.

Bug: 938893
Change-Id: If0a682414b27912c8ff55b4bc0e477c9948ba051
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1511415
Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#640228}