Google Git
Sign in
chromium / chromium / src / cf1b28fcebe7d86dd3c75fade6a2830c0b835ecc
commitcf1b28fcebe7d86dd3c75fade6a2830c0b835ecc[log] [tgz]
authorNoémie St-Onge <noemies@google.com>Wed Jul 02 13:22:20 2025
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Jul 02 13:22:20 2025
tree461c88d4b1eb29a769fbfdc6ac140b474834f769
parenta8c0643b7bff8141aa1214a0c3a231ecd9e4f03c [diff]
[iOS] Fix condition for appending •••• suffix to password suggestions

When the Keyboard Accessory upgrade feature is off, we append the
"••••••••" suffix to all KA suggestions that match the `kPassword`
filling product. However, we really only want to append the suffix to
suggestions that are reflecting the user's saved data, and not to
generic suggestions such as the "Suggest strong password" one.

Because generic suggestions are also included in the `kPassword` filling
product, having the filling product being the deciding factor for
showing/not showing the suffix is erroneous, and leads to having the
suffix appended to generic suggestions.

This CL fixes the issue by directly looking at the suggestions' type
instead.

Fixed: 428191407, 428190053
Change-Id: Ibca4f0f94079b97d42c81e614995f8f91a036745
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6685675
Reviewed-by: Vincent Boisselle <vincb@google.com>
Commit-Queue: Noémie St-Onge <noemies@google.com>
Cr-Commit-Position: refs/heads/main@{#1481547}
3 files changed
tree: 461c88d4b1eb29a769fbfdc6ac140b474834f769
  1. .github/
  2. android_webview/
  3. apps/
  4. ash/
  5. base/
  6. build/
  7. build_overrides/
  8. buildtools/
  9. cc/
  10. chrome/
  11. chromecast/
  12. chromeos/
  13. codelabs/
  14. components/
  15. content/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. gpu/
  25. headless/
  26. infra/
  27. ios/
  28. ipc/
  29. media/
  30. mojo/
  31. net/
  32. pdf/
  33. ppapi/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. clank
  50. internal
  51. ios_internal
  52. signing_keys
  53. v8
  54. .clang-format
  55. .clang-tidy
  56. .clangd
  57. .cursorignore
  58. .git-blame-ignore-revs
  59. .gitallowed
  60. .gitattributes
  61. .gitignore
  62. .gitmodules
  63. .gn
  64. .mailmap
  65. .rustfmt.toml
  66. .vpython3
  67. .yapfignore
  68. ATL_OWNERS
  69. AUTHORS
  70. BUILD.gn
  71. CODE_OF_CONDUCT.md
  72. codereview.settings
  73. CPPLINT.cfg
  74. CRYPTO_OWNERS
  75. DEPS
  76. DIR_METADATA
  77. LICENSE
  78. LICENSE.chromium_os
  79. OWNERS
  80. PRESUBMIT.py
  81. PRESUBMIT_test.py
  82. PRESUBMIT_test_mocks.py
  83. README.md
  84. SECURITY_OWNERS
  85. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.