[Autofill] Check for self-destruction after selecting a suggestions. This UAF was introduced in crrev.com/c/3297919 by hiding the popup in SetSelectedLine() if the window holds a pointer lock. Since hiding the popup deletes the popup, |this| must not be accessed afterwards. This CL is a quick fix that adds checks after calling SetSelectedLine(). The followup CLs will make this and other checks for weak_this redundant: crrev.com/c/3317979, crrev.com/c/3318297. Bug: 1276850, 1239496 Change-Id: I79ce4df48ae969ba13033640f2ac2ac8c322373b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3318616 Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org> Auto-Submit: Christoph Schwering <schwering@google.com> Commit-Queue: Christoph Schwering <schwering@google.com> Cr-Commit-Position: refs/heads/main@{#949363}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.