Call IsolateAllSitesForTesting earlier in test setup. Calling IsolateAllSitesForTesting() in a test body may lead to inconsistent results for test expectations that rely on AreOriginKeyedProcessesEnabledByDefault, since that allows the main frame to be created with an incorrect default isolation state. This CL fixes NavigationRequestBrowserTest.StartToCommitMetrics to call IsolateAllSitesForTesting() in SetUpCommandLine instead to avoid this problem. Bug: 40259221 Change-Id: I022252d0455f717dee3f62a73de88552bcd3a4a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5716898 Commit-Queue: James Maclean <wjmaclean@chromium.org> Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/main@{#1329056}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.