Google Git
Sign in
chromium / chromium / src / cf4d4c633d6448a60f3dde648f74c26298a9b46d
commitcf4d4c633d6448a60f3dde648f74c26298a9b46d[log] [tgz]
authorAntonio Rivera <antoniori@google.com>Wed May 21 01:52:31 2025
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed May 21 01:52:31 2025
tree802a07d11bc4b5d761ba505419415727cbd18407
parentdda4473b47e14b5500630d38fc856ef0015608d6 [diff]
Fix default HEVC level.

I couldn't find any clear explanation of the formatting of the level
field in HEVC MIME strings, but this IANA document mentions:

"If no tier-flag is present, a value of 0 MUST be inferred; if no
level-id is present, a value of 93 (i.e., level 3.1) MUST be inferred"
https://www.iana.org/assignments/media-types/video/H265

This implies that the integer representation of HEVC level is 30 *
level.

As-is, this causes an issue when casting HEVC content via progressive
(src=) playback. FFmpegDemuxer is used in that case, and that calls
MediaClient::IsDecoderSupportedVideoType
(https://source.chromium.org/chromium/chromium/src/+/main:media/filters/ffmpeg_demuxer.cc;l=247;drc=784100735e7a0d04f97433ba7c55f6d4df94138b)
with level=10. Linux cast devices convert this info back to a MIME
string for checking starboard decoder support
(https://github.com/youtube/cobalt/blob/a3bf3081ae3bb89abe15c8a9a07764e193610321/starboard/media.h#L535),
and that leads to an invalid HEVC MIME type.

Bug: None
Change-Id: Ica4e952dd83e22823d3eaa68f1291775414b5aee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6565875
Commit-Queue: Antonio Rivera <antoniori@google.com>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1463183}
1 file changed
tree: 802a07d11bc4b5d761ba505419415727cbd18407
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. gpu/
  24. headless/
  25. infra/
  26. ios/
  27. ipc/
  28. media/
  29. mojo/
  30. native_client_sdk/
  31. net/
  32. pdf/
  33. ppapi/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. clank
  50. internal
  51. ios_internal
  52. native_client
  53. signing_keys
  54. v8
  55. .clang-format
  56. .clang-tidy
  57. .clangd
  58. .git-blame-ignore-revs
  59. .gitallowed
  60. .gitattributes
  61. .gitignore
  62. .gitmodules
  63. .gn
  64. .mailmap
  65. .rustfmt.toml
  66. .vpython3
  67. .yapfignore
  68. ATL_OWNERS
  69. AUTHORS
  70. BUILD.gn
  71. CODE_OF_CONDUCT.md
  72. codereview.settings
  73. CPPLINT.cfg
  74. CRYPTO_OWNERS
  75. DEPS
  76. DIR_METADATA
  77. LICENSE
  78. LICENSE.chromium_os
  79. OWNERS
  80. PRESUBMIT.py
  81. PRESUBMIT_test.py
  82. PRESUBMIT_test_mocks.py
  83. README.md
  84. SECURITY_OWNERS
  85. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.