Various clean-ups in SyncInternalsMessageHandlerTest Test-only change. 1. Modernize use of base::Value APIs. 2. Override UserEventService earlier, in GetTestingFactories(). 3. Use a MockSyncInvalidationsService instead of the real one. 4. Remove last_delegate_sync_service() which has little use. 5. about_information() -> kAboutInformation 6. Reduce number of APIs that TestableSyncInternalsMessageHandler needs to publicize. 7. Remove the SendAboutInfoSyncDisabled test, which verifies an impossible scenario - OnStateChanged() notification when SyncService is null. 8. Make ConstructFakeAboutInformation() private. Bug: 360321896 Change-Id: Ibe00dcb3091fab677702e617e3be1455b3a3d7e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5797069 Reviewed-by: Mahmoud Rashad <mmrashad@google.com> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/main@{#1344098}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.