| commit | cf5f46a8559c5beec7f8fc97d02a389e4438a6d4 | [log] [tgz] |
|---|---|---|
| author | Keita Suzuki <suzukikeita@chromium.org> | Mon Apr 28 07:55:53 2025 |
| committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Apr 28 07:55:53 2025 |
| tree | 4c99f405644002845004b3e01ea4eaa52793276f | |
| parent | 606b7c540cc307bd8e09f26d8d3478d42595fcca [diff] |
Enable periodic ping on QUIC connection with the passed config This CL enables periodic ping on QUIC connection with the passed `ConnectionManagementConfig`. This initializes the `QuicConnection` with the passed periodic ping interval and idle timeout settings. It also enables periodic ping in the `QuicChromiumClientSession`. When periodic ping is enabled, we set `ShouldKeepConnectionAlive` to always return true. Currently, Quiche sends pings when we send / receive QUIC packets, and when there is an outstanding request in flight. To determine this, Quiche checks `quic::QuicSpdyClientSessionBase::ShouldKeepConnectionAlive`, which returns true when we have an outstanding request in flight. This means that we will only send PINGs when we have an request, which will block periodic pings for connection keep alive when we don't have any requests. By always returning true when periodic ping is enabled, we will be able to send out pings periodically, since sending the PING frames will rearm the connection keep alive alarms even without any in flight requests. Bug: 406022435 Change-Id: Ia6c5c1467a70367644d6be8fc7a8f334effec92a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6474006 Reviewed-by: Nidhi Jaju <nidhijaju@chromium.org> Commit-Queue: Keita Suzuki <suzukikeita@chromium.org> Cr-Commit-Position: refs/heads/main@{#1452446}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.