[DevTools] Remove warning note for proxy
Since Runtime.getProperties doesn't produce side effects for proxies we can remove this note.
BUG=139774
R=lushnikov@chromium.org
Review-Url: https://codereview.chromium.org/1953653002
Cr-Commit-Position: refs/heads/master@{#391770}
diff --git a/third_party/WebKit/LayoutTests/TestExpectations b/third_party/WebKit/LayoutTests/TestExpectations
index 644a64a..762ab5b6c 100644
--- a/third_party/WebKit/LayoutTests/TestExpectations
+++ b/third_party/WebKit/LayoutTests/TestExpectations
@@ -1325,8 +1325,6 @@
crbug.com/606649 fast/dom/gc-dom-tree-lifetime.html [ Pass Timeout ]
-crbug.com/588705 inspector/console/console-proxy.html [ NeedsManualRebaseline ]
-
# TODO(jlebel): Remove when methods are implemented.
crbug.com/609065 [ Mac ] bluetooth/characteristicProperties.html [ Skip ]
crbug.com/609064 [ Mac ] bluetooth/getCharacteristic/blacklisted-characteristic.html [ Skip ]
diff --git a/third_party/WebKit/LayoutTests/inspector/console/console-proxy-expected.txt b/third_party/WebKit/LayoutTests/inspector/console/console-proxy-expected.txt
index e83259de..28e43a7c 100644
--- a/third_party/WebKit/LayoutTests/inspector/console/console-proxy-expected.txt
+++ b/third_party/WebKit/LayoutTests/inspector/console/console-proxy-expected.txt
@@ -2,14 +2,12 @@
CONSOLE MESSAGE: line 23: [object Proxy]
Tests that console logging dumps proxy properly.
-warning-note display: inline-block
info-note display: none
-console-proxy.html:21 Proxy {boo: 42, foo: 43} console-message-text source-code > console-message-url webkit-html-resource-link > object-value-proxy source-code > console-view-object-properties-section > tree-outline-disclosure tree-outline-disclosure-hide-overflow > tree-outline source-code object-properties-section > parent object-properties-section-root-element > selection fill > console-object-preview > name > object-value-number > name > object-value-number > object-state-note warning-note > object-state-note info-note > children
-console-proxy.html:23 Proxy {boo: 42, foo: 43} console-message-text source-code > console-message-url webkit-html-resource-link > object-value-proxy source-code > console-view-object-properties-section > tree-outline-disclosure tree-outline-disclosure-hide-overflow > tree-outline source-code object-properties-section > parent object-properties-section-root-element > selection fill > console-object-preview > name > object-value-number > name > object-value-number > object-state-note warning-note > object-state-note info-note > children
+console-proxy.html:21 Proxy {boo: 42, foo: 43} console-message-text source-code > console-message-url webkit-html-resource-link > object-value-proxy source-code > console-view-object-properties-section > tree-outline-disclosure tree-outline-disclosure-hide-overflow > tree-outline source-code object-properties-section > parent object-properties-section-root-element > selection fill > console-object-preview > name > object-value-number > name > object-value-number > object-state-note info-note > children
+console-proxy.html:23 Proxy {boo: 42, foo: 43} console-message-text source-code > console-message-url webkit-html-resource-link > object-value-proxy source-code > console-view-object-properties-section > tree-outline-disclosure tree-outline-disclosure-hide-overflow > tree-outline source-code object-properties-section > parent object-properties-section-root-element > selection fill > console-object-preview > name > object-value-number > name > object-value-number > object-state-note info-note > children
window.accessedGet = false
-warning-note display: none
info-note display: inline-block
-console-proxy.html:21 Proxy {boo: 42, foo: 43}[[Handler]]: Object[[Target]]: Object[[IsRevoked]]: false console-message-text source-code > console-message-url webkit-html-resource-link > object-value-proxy source-code > console-view-object-properties-section expanded > tree-outline-disclosure tree-outline-disclosure-hide-overflow > tree-outline source-code object-properties-section > parent object-properties-section-root-element expanded > selection fill > console-object-preview > name > object-value-number > name > object-value-number > object-state-note warning-note > object-state-note info-note > children expanded > parent > selection fill > name > object-properties-section-separator > value object-value-object > children > parent > selection fill > name > object-properties-section-separator > value object-value-object > children > selection fill > name > object-properties-section-separator > value object-value-boolean > children
-console-proxy.html:23 Proxy {boo: 42, foo: 43}[[Handler]]: Object[[Target]]: Proxy[[IsRevoked]]: false console-message-text source-code > console-message-url webkit-html-resource-link > object-value-proxy source-code > console-view-object-properties-section expanded > tree-outline-disclosure tree-outline-disclosure-hide-overflow > tree-outline source-code object-properties-section > parent object-properties-section-root-element expanded > selection fill > console-object-preview > name > object-value-number > name > object-value-number > object-state-note warning-note > object-state-note info-note > children expanded > parent > selection fill > name > object-properties-section-separator > value object-value-object > children > parent > selection fill > name > object-properties-section-separator > value object-value-proxy > children > selection fill > name > object-properties-section-separator > value object-value-boolean > children
+console-proxy.html:21 Proxy {boo: 42, foo: 43}[[Handler]]: Object[[Target]]: Object[[IsRevoked]]: false console-message-text source-code > console-message-url webkit-html-resource-link > object-value-proxy source-code > console-view-object-properties-section expanded > tree-outline-disclosure tree-outline-disclosure-hide-overflow > tree-outline source-code object-properties-section > parent object-properties-section-root-element expanded > selection fill > console-object-preview > name > object-value-number > name > object-value-number > object-state-note info-note > children expanded > parent > selection fill > name > object-properties-section-separator > value object-value-object > children > parent > selection fill > name > object-properties-section-separator > value object-value-object > children > selection fill > name > object-properties-section-separator > value object-value-boolean > children
+console-proxy.html:23 Proxy {boo: 42, foo: 43}[[Handler]]: Object[[Target]]: Proxy[[IsRevoked]]: false console-message-text source-code > console-message-url webkit-html-resource-link > object-value-proxy source-code > console-view-object-properties-section expanded > tree-outline-disclosure tree-outline-disclosure-hide-overflow > tree-outline source-code object-properties-section > parent object-properties-section-root-element expanded > selection fill > console-object-preview > name > object-value-number > name > object-value-number > object-state-note info-note > children expanded > parent > selection fill > name > object-properties-section-separator > value object-value-object > children > parent > selection fill > name > object-properties-section-separator > value object-value-proxy > children > selection fill > name > object-properties-section-separator > value object-value-boolean > children
window.accessedGet = false
diff --git a/third_party/WebKit/LayoutTests/inspector/console/console-proxy.html b/third_party/WebKit/LayoutTests/inspector/console/console-proxy.html
index 3a91b11..1371e6c 100644
--- a/third_party/WebKit/LayoutTests/inspector/console/console-proxy.html
+++ b/third_party/WebKit/LayoutTests/inspector/console/console-proxy.html
@@ -33,7 +33,6 @@
var consoleView = WebInspector.ConsoleView.instance();
consoleView._viewport.invalidate()
var element = consoleView._visibleViewMessages[0].contentElement();
- dumpNoteVisible(element, "warning-note");
dumpNoteVisible(element, "info-note");
InspectorTest.dumpConsoleMessages(false, true);
@@ -49,7 +48,6 @@
function dumpExpandedConsoleMessages()
{
var element = WebInspector.ConsoleView.instance()._visibleViewMessages[0].contentElement();
- dumpNoteVisible(element, "warning-note");
dumpNoteVisible(element, "info-note");
InspectorTest.dumpConsoleMessages(false, true);
diff --git a/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js b/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js
index a5ee48b..53c190c5 100644
--- a/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js
+++ b/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js
@@ -425,11 +425,6 @@
titleElement.createTextChild(obj.description || "");
}
}
- if (obj.subtype === "proxy") {
- var warning = titleElement.createChild("span", "object-state-note");
- warning.classList.add("warning-note");
- warning.title = WebInspector.UIString("Expansion of the Proxy object can lead to JavaScript execution.");
- }
var note = titleElement.createChild("span", "object-state-note");
note.classList.add("info-note");
note.title = WebInspector.UIString("Object value at left was snapshotted when logged, value below was evaluated just now.");
diff --git a/third_party/WebKit/Source/devtools/front_end/console/consoleView.css b/third_party/WebKit/Source/devtools/front_end/console/consoleView.css
index b37f0a6..ab3d1f0 100644
--- a/third_party/WebKit/Source/devtools/front_end/console/consoleView.css
+++ b/third_party/WebKit/Source/devtools/front_end/console/consoleView.css
@@ -449,18 +449,6 @@
content: "i";
}
-.warning-note {
- background-color: rgb(255, 161, 45);
-}
-
-.warning-note::before {
- content: "!";
-}
-
.console-view-object-properties-section:not(.expanded) .info-note {
display: none;
}
-
-.console-view-object-properties-section.expanded .warning-note {
- display: none;
-}
