Google Git
Sign in
chromium / chromium / src / a25696cbeaff6d2065b7bf446ac8d7aaf47c4f9a
commita25696cbeaff6d2065b7bf446ac8d7aaf47c4f9a[log] [tgz]
authorKristi Park <kristipark@chromium.org>Thu Mar 14 02:12:54 2019
committerCommit Bot <commit-bot@chromium.org>Thu Mar 14 02:12:54 2019
treebc48da5c136e95b11387465915a303cd181f2fc8
parent2f0ded1a7eba7d8cc7a749d5156b1d98e1cf81f6 [diff]
[NTP] Fix promo overlapping with toast notifications

When the delayed notification timeout was executed early, the promo was
re-shown instead of remaining hidden. Do not show the promo if the
delayed timeout was executed early.

Also adjust the notification handlers to match remote NTP
(cl/213513740). This allows us to apply float animations to the promo
as well.

Screencast: https://drive.google.com/open?id=1gnFuRL5wFO-LoqATO0t6PQx05RTmn85w

Bug: 941247
Change-Id: Ie68a3a78eb141af928c431813b8dc45fe586c800
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518502
Commit-Queue: Kristi Park <kristipark@chromium.org>
Reviewed-by: Kyle Milka <kmilka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#640590}
1 file changed
tree: bc48da5c136e95b11387465915a303cd181f2fc8
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .