Google Git
Sign in
chromium / chromium / src / cf970af0e5b24c0a2c76192e3727893ba8fa34d1
commitcf970af0e5b24c0a2c76192e3727893ba8fa34d1[log] [tgz]
authorAdam Langley <agl@chromium.org>Sat Feb 09 01:28:07 2019
committerCommit Bot <commit-bot@chromium.org>Sat Feb 09 01:28:07 2019
tree25849ca259747f2e658bdd642646d16558df2302
parent3d14c4f89d065def7a1b862165ec2e0f893d2fb8 [diff]
Fix |AuthenticatorSupportedOptions.user_presence_required|.

In the authenticator options, the “up” flag doesn't mean that user
presence is required, it means that the authenticator supports obtaining
it. So, firstly, rename that field to correctly reflect the semantics.

Secondly, implement this in the virtual CTAP2 device.

(The purpose of this field is a little unclear: creating a credential
unconditionally requires user-presence in the spec. Therefore an
authenticator that's not capable of testing it can never create any
credentials and would appear to be useless. But there we go.)

Change-Id: I129f825a3732da1e0521182f2dc1bc4c9e26e038
Reviewed-on: https://chromium-review.googlesource.com/c/1450640
Commit-Queue: Adam Langley <agl@chromium.org>
Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Cr-Commit-Position: refs/heads/master@{#630591}
6 files changed
tree: 25849ca259747f2e658bdd642646d16558df2302
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. mash/
  33. media/
  34. mojo/
  35. native_client_sdk/
  36. net/
  37. pdf/
  38. ppapi/
  39. printing/
  40. remoting/
  41. rlz/
  42. sandbox/
  43. services/
  44. skia/
  45. sql/
  46. storage/
  47. styleguide/
  48. testing/
  49. third_party/
  50. tools/
  51. ui/
  52. url/
  53. .clang-format
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. AUTHORS
  61. BUILD.gn
  62. CODE_OF_CONDUCT.md
  63. codereview.settings
  64. DEPS
  65. ENG_REVIEW_OWNERS
  66. LICENSE
  67. LICENSE.chromium_os
  68. OWNERS
  69. PRESUBMIT.py
  70. PRESUBMIT_test.py
  71. PRESUBMIT_test_mocks.py
  72. README.md
  73. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .