Google Git
Sign in
chromium / chromium / src / cfc3663e253baf6048207db4f1a120d7c8fbb896
commitcfc3663e253baf6048207db4f1a120d7c8fbb896[log] [tgz]
authorTim Sergeant <tsergeant@chromium.org>Mon Nov 07 00:49:55 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Mon Nov 07 00:49:55 2022
tree4e8657401ba09fe2452f1d59957ab482aadd8315
parent6234b5c211d341e6af8933fec39f306681cdde66 [diff]
Revert "cert_verify_proc_unittest: Start adding tests of root constraints"

This reverts commit eda3b20bad2b5880c0799f77f0b37d72a6326de8.

Reason for revert: New tests fail on Mac and iOS builders, e.g.:

https://ci.chromium.org/ui/p/chromium/builders/ci/ios-simulator-noncq/b8798378773839220081/overview
https://ci.chromium.org/ui/p/chromium/builders/ci/Mac10.14%20Tests/b8798375061732439649/overview

Original change's description:
> cert_verify_proc_unittest: Start adding tests of root constraints
>
> Test how constraints on roots are handled on each implementation.
>
> Also tests handling of constraints on intermediates. This clarifies whether a root constraint not being handled is due to not implementing that constraint at all or just due to not enforcing it on roots. It also is just nice to have for completeness.
>
> This CL adds tests of basicConstraints and nameConstraints.
>
> Bug: 1370748
> Change-Id: I621800224cbfb035d1c18df6a7894f66c2e2d807
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3997424
> Reviewed-by: David Benjamin <davidben@chromium.org>
> Commit-Queue: Matt Mueller <mattm@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1067786}

Bug: 1370748, 1381904
Change-Id: Ibfa511bbb974bcc71205120cdb29e9a547c9a139
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4005546
Auto-Submit: Tim Sergeant <tsergeant@chromium.org>
Owners-Override: Tim Sergeant <tsergeant@chromium.org>
Commit-Queue: Tim Sergeant <tsergeant@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1067943}
3 files changed
tree: 4e8657401ba09fe2452f1d59957ab482aadd8315
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. AUTHORS
  63. BUILD.gn
  64. CODE_OF_CONDUCT.md
  65. codereview.settings
  66. DEPS
  67. DIR_METADATA
  68. ENG_REVIEW_OWNERS
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.