Google Git
Sign in
chromium / chromium / src / cfeafebe5ae705108a31cf39cd299726d89eafdb
commitcfeafebe5ae705108a31cf39cd299726d89eafdb[log] [tgz]
authorJean-Philippe Gravel <jpgravel@chromium.org>Tue Apr 08 15:32:11 2025
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue Apr 08 15:32:11 2025
tree6fa6785e690c5a406071c489a2741a98300d6cc8
parent8db7ba1fa445e8911d4218f8372ab4a6469cf90d [diff]
Remove GetOrCreateCanvasResourceProvider hint parameter

This parameter was unused. It was forwarded to
GetOrCreateCanvasResourceProviderImpl, which only uses the hint for 2D
HTMLCanvasElement contexts [1]. HTMLCanvasElement however overrides
GetOrCreateCanvasResourceProvider and never uses the provided hint for
2D contexts [2]. Thus, the hint was effectively never used.

[1]:
https://crsrc.org/c/third_party/blink/renderer/core/html/canvas/canvas_rendering_context_host.cc;l=137;drc=700521753d9cca1d40fb19e050031b32fdfd3973

[2]:
https://crsrc.org/c/third_party/blink/renderer/core/html/canvas/html_canvas_element.cc;l=2115;drc=78883e6c824fd669688b9943096a7b01f87c1cb5

Bug: 346766781
Change-Id: Ia4a9685f87e45a2285807d26dc7789559369cb4a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6437450
Commit-Queue: Jean-Philippe Gravel <jpgravel@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1444139}
13 files changed
tree: 6fa6785e690c5a406071c489a2741a98300d6cc8
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. gpu/
  24. headless/
  25. infra/
  26. ios/
  27. ipc/
  28. media/
  29. mojo/
  30. native_client_sdk/
  31. net/
  32. pdf/
  33. ppapi/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. clank
  50. internal
  51. ios_internal
  52. native_client
  53. signing_keys
  54. v8
  55. .clang-format
  56. .clang-tidy
  57. .clangd
  58. .git-blame-ignore-revs
  59. .gitallowed
  60. .gitattributes
  61. .gitignore
  62. .gitmodules
  63. .gn
  64. .mailmap
  65. .rustfmt.toml
  66. .vpython3
  67. .yapfignore
  68. ATL_OWNERS
  69. AUTHORS
  70. BUILD.gn
  71. CODE_OF_CONDUCT.md
  72. codereview.settings
  73. CPPLINT.cfg
  74. CRYPTO_OWNERS
  75. DEPS
  76. DIR_METADATA
  77. LICENSE
  78. LICENSE.chromium_os
  79. OWNERS
  80. PRESUBMIT.py
  81. PRESUBMIT_test.py
  82. PRESUBMIT_test_mocks.py
  83. README.md
  84. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.