| commit | d01806c9b815ee4c47a96cdaa57c97f30dd5f8ff | [log] [tgz] |
|---|---|---|
| author | Victor Hugo Vianna Silva <victorvianna@google.com> | Fri Jun 17 14:27:33 2022 |
| committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Jun 17 14:27:33 2022 |
| tree | a047fc5c83e6bb814e32d901538029ef31211762 | |
| parent | 46dd73974f957404dc5d78378a8304ff5d704abe [diff] |
[send-tab-to-self/iOS] Send generic shareURL instead of current page Before this CL, SendTabToSelfCoordinator would always send the current tab's URL by invoking SendTabToSelfBrowserAgent::SendCurrentTabToDevice(). This CL - Starts sending shareURL[1][2] instead. In future CLs this will will allow link sharing, a flow where the sent URL is not the current page. - Inlines the SendTabToSelfBrowserAgent method. This was already quite a thin wrapper around SendTabToSelfModel::AddEntry() and it would become even thinner with these code changes. [1] https://source.chromium.org/chromium/chromium/src/+/main:ios/chrome/browser/ui/activity_services/data/share_to_data_builder.mm;l=90;drc=5938e3414233044ac44257571be0f95228adeb72 [2] https://source.chromium.org/chromium/chromium/src/+/main:ios/chrome/browser/ui/activity_services/data/share_to_data_builder.mm;l=84;drc=5938e3414233044ac44257571be0f95228adeb72 Bug: 1324287, 1274173 Change-Id: If1241c88112b533eef4f3fec76a7ee4ee9d8c724 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3705360 Auto-Submit: Victor Vianna <victorvianna@google.com> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/main@{#1015342}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.