commit d044a3a63a1aee2dbceaafbddcd69f78974440a0
author Paul Adedeji <pauladedeji@google.com> Wed Feb 05 22:45:47 2025
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Wed Feb 05 22:45:47 2025
tree c3aecd8aeca96e8c43f41b76eb6e3435ce5191d7
parent c0b6f2f0d314422a1cd22905196f4668a43bf38f

[ntp modules] Decouple load/reload logic (bug fix).

`loadModules()` loads the NTP modules container. Currently, it is
callable on initial load[1] and during reload[2] (if no modules shown
and module reload behavior is feature enabled), leading to potential
conflicts.

This change
1. Makes `loadModules()` only callable during initial load. Modules
enabled during this initial load will wait for it to finish before being
loaded into the container.
2. Restricts reload logic, so that it can only be triggered after
`loadModules()` has started loading modules. Otherwise, we can assume
that `loadModules()` will be called at some point in the future, and
that we don't need to reload anything yet.
3. Checks for an existing template instance right before creating a new
one. This prevents race conditions where another part of the code might have added the instance in the meantime.

[1]https://source.chromium.org/chromium/chromium/src/+/main:chrome/browser/resources/new_tab_page/modules/v2/modules.ts;drc=3e99cfbf333b0e33b0f656682260b6b78f6368ff;l=301
[2]https://source.chromium.org/chromium/chromium/src/+/main:chrome/browser/resources/new_tab_page/modules/v2/modules.ts;drc=3e99cfbf333b0e33b0f656682260b6b78f6368ff;l=333

Change-Id: Ifc3cf09ac258c5d8312cda9372149c8a6c1ad19e
Bug: 394335176
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6231292
Reviewed-by: Riley Tatum <rtatum@google.com>
Commit-Queue: Paul Adedeji <pauladedeji@google.com>
Cr-Commit-Position: refs/heads/main@{#1416480}