commit | d0ea5acf1b288b4217a694511748b508823d07f4 | [log] [tgz] |
---|---|---|
author | Elly <ellyjones@chromium.org> | Thu Apr 03 15:58:54 2025 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Apr 03 15:58:54 2025 |
tree | 4bd037e5ad9a8075958219cc52459df93c8dc1dc | |
parent | f735d8d371dd0e4e8a90cb5c184ecb558f7a56b1 [diff] |
ash/quick_start: migrate from crypto/sha2 to crypto/hash Specifically, this change: * Drops the (test-only) deps on crypto::SHA256HashString() in favor of using a hardcoded client data hash; * Adds an extra assertion to one of the unit tests that the client data hash is actually included when generating an assertion request; * Has some of the message factory functions take their client data hashes as base::span rather than std::array (which saves a copy); * Corrects a misuse of base::span (const span<T> just means span<T>, the code wanted span<const T> instead) * Removes two redundant data copies in BuildNotifySourceOfUpdateMessage; * Adds some `auto` where it does not reduce clarity, which makes the code a bit more compact Bug: 374310081 Change-Id: Ic6c4a91da628a01805c8cc97897e83b31a539d04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6423849 Reviewed-by: Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Elly FJ <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/main@{#1442192}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.