[download] Fix SavePackage::TruncateBaseNameToFitPathConstraints Resolves long-standing issues with filename truncation in SavePackage: * Fix encoding-unaware truncation on POSIX systems by using UTF-8 safe truncation with base::TruncateUTF8ToByteSize() to respect character boundaries instead of unsafe byte-level substr(). * Replace hardcoded filesystem constants with runtime queries using base::GetMaximumPathComponentLength() in ComputeMaxPathLengthForDirectory() when blocking I/O is allowed (file threads). * Implement two-tier architecture: runtime filesystem queries during path selection and conservative platform defaults during save operations to avoid blocking I/O on UI thread. * Add proper UTF-8 encoding conversion on POSIX (AsUTF8Unsafe/FromUTF8Unsafe) with fallback handling for edge cases. * Update comments and method names for clarity between blocking (ComputeMaxPathLengthForDirectory) and non-blocking (GetMaxPathLengthForDirectory) variants. * Add comprehensive test coverage for UTF-8 truncation, edge cases, and cross-platform compatibility including Fuchsia support. Bug: 41258047 Change-Id: I9772618bc9eae0e48f0b85a6d0ccee82d057a276 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6809425 Commit-Queue: Ho Cheung <hocheung@chromium.org> Reviewed-by: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/main@{#1497291}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.