[download] Fix SavePackage::TruncateBaseNameToFitPathConstraints

Resolves long-standing issues with filename truncation in SavePackage:

* Fix encoding-unaware truncation on POSIX systems by using UTF-8 safe
truncation with base::TruncateUTF8ToByteSize() to respect character
boundaries instead of unsafe byte-level substr().

* Replace hardcoded filesystem constants with runtime queries using
base::GetMaximumPathComponentLength() in
ComputeMaxPathLengthForDirectory() when blocking I/O is allowed (file
threads).

* Implement two-tier architecture: runtime filesystem queries during
path selection and conservative platform defaults during save operations
to avoid blocking I/O on UI thread.

* Add proper UTF-8 encoding conversion on POSIX (AsUTF8Unsafe/FromUTF8Unsafe)
with fallback handling for edge cases.

* Update comments and method names for clarity between blocking
(ComputeMaxPathLengthForDirectory) and non-blocking
(GetMaxPathLengthForDirectory) variants.

* Add comprehensive test coverage for UTF-8 truncation, edge cases, and
cross-platform compatibility including Fuchsia support.

Bug: 41258047
Change-Id: I9772618bc9eae0e48f0b85a6d0ccee82d057a276
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6809425
Commit-Queue: Ho Cheung <hocheung@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1497291}
3 files changed
tree: 1807ce1866da918a1067da94e77a5a16af3b5e86
  1. .github/
  2. agents/
  3. android_webview/
  4. apps/
  5. ash/
  6. base/
  7. build/
  8. build_overrides/
  9. buildtools/
  10. cc/
  11. chrome/
  12. chromecast/
  13. chromeos/
  14. codelabs/
  15. components/
  16. content/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia_web/
  23. gin/
  24. google_apis/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. net/
  33. pdf/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. .clang-format
  50. .clang-tidy
  51. .clangd
  52. .cursorignore
  53. .geminiignore
  54. .git-blame-ignore-revs
  55. .gitallowed
  56. .gitattributes
  57. .gitignore
  58. .gitmodules
  59. .gn
  60. .mailmap
  61. .rustfmt.toml
  62. .vpython3
  63. .yapfignore
  64. ATL_OWNERS
  65. AUTHORS
  66. BUILD.gn
  67. CODE_OF_CONDUCT.md
  68. codereview.settings
  69. CPPLINT.cfg
  70. CRYPTO_OWNERS
  71. DEPS
  72. DIR_METADATA
  73. LICENSE
  74. LICENSE.chromium_os
  75. OWNERS
  76. PRESUBMIT.py
  77. PRESUBMIT_test.py
  78. PRESUBMIT_test_mocks.py
  79. README.md
  80. SECURITY_OWNERS
  81. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.