commit | d14306c17afaec9da2472d19fe443f96580776a5 | [log] [tgz] |
---|---|---|
author | Yue Zhang <yuezhanggg@chromium.org> | Wed Feb 19 00:02:16 2025 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Feb 19 00:02:16 2025 |
tree | 597035e32ac1b4e3467b75615a282493162998a9 | |
parent | bcf216f16133270a3deaad650a22c6879c673ab9 [diff] |
Revert "[a11y] Ensure AXObject::ToString() is called only after Init()" This reverts commit 04f2270194cb745744c5e2da840cc1299776b8e1. Reason for revert: Causing test failure on Android, see b/397515684. Original change's description: > [a11y] Ensure AXObject::ToString() is called only after Init() > > Calling AXObject::ToString() before Init() can > lead to a segfault in the renderer process without > a stack trace. This makes debugging extremely > difficult, especially when adding logging > statements, as each additional log that > potentially calls ToString() before Init() > increases the likelihood of a crash. > > This change adds a check to ensure that Init() has > been called before ToString() is executed, > preventing the segfault and improving > debuggability. > > Change-Id: If9acb9592e6310af274cadacb75b99d18585cecd > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6271111 > Reviewed-by: Aaron Leventhal <aleventhal@chromium.org> > Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1421634} Change-Id: I487788ac6658b4e2e02d08d21497673bf421bd3f No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6279747 Auto-Submit: Yue Zhang <yuezhanggg@chromium.org> Reviewed-by: Yue Zhang <yuezhanggg@chromium.org> Owners-Override: Yue Zhang <yuezhanggg@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1421688}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.